Merge aaf7f9f into 613994a

SaschaCowley · web-flow · commit c8099b97fcc2 · 2024-05-22T07:22:00.000Z
diff --git a/nvdaHelper/vbufBackends/gecko_ia2/gecko_ia2.cpp b/nvdaHelper/vbufBackends/gecko_ia2/gecko_ia2.cpp
@@ -954,7 +954,7 @@ VBufStorage_fieldNode_t* GeckoVBufBackend_t::fillVBuf(
 			
 			{ // Add the table summary if one is present and the table is visible.
 				VBufStorage_fieldNode_t* summaryTempNode = nullptr;
-				if (isVisible && description.has_value()) {
+				if (isVisible && description.has_value() && !description.value().empty()) {
 					tempNode = summaryTempNode = buffer->addTextFieldNode(parentNode, previousNode, description.value());
 				}
 				else if (
diff --git a/user_docs/en/changes.md b/user_docs/en/changes.md
@@ -32,6 +32,7 @@
   * NVDA will no longer announce "clipboard history" twice when navigating through the emoji panel menu items. (#16532, @josephsl)
   * NVDA will no longer cut off speech and braille when reviewing kaomojis and symbols in the emoji panel. (#16533, @josephsl)
 * In applications using Java Access Bridge, NVDA will now correctly read the last blank line of a text instead of repeating the previous line. (#9376, @dmitrii-drobotov)
+* If present, NVDA will now use `aria-labelledby` to provide accessible names for tables in Mozilla Firefox. (#5183)
 
 ### Changes for Developers
 

Original file line number	Diff line number	Diff line change
`@@ -954,7 +954,7 @@ VBufStorage_fieldNode_t* GeckoVBufBackend_t::fillVBuf(`
`954`	`954`
`955`	`955`	`{ // Add the table summary if one is present and the table is visible.`
`956`	`956`	`VBufStorage_fieldNode_t* summaryTempNode = nullptr;`
`957`		`- if (isVisible && description.has_value()) {`
	`957`	`+ if (isVisible && description.has_value() && !description.value().empty()) {`
`958`	`958`	`tempNode = summaryTempNode = buffer->addTextFieldNode(parentNode, previousNode, description.value());`
`959`	`959`	`}`
`960`	`960`	`else if (`