Skip to content

Commit bbf2b78

Browse files
authored
Merge 922f0fb into 8205206
2 parents 8205206 + 922f0fb commit bbf2b78

3 files changed

Lines changed: 12 additions & 10 deletions

File tree

source/buildVersion.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ def formatVersionForGUI(year, major, minor):
7070
version_minor = 0
7171
version_build = 0 # Should not be set manually. Set in 'sconscript' provided by 'appVeyor.yml'
7272
version=_formatDevVersionString()
73+
version_detailed = formatBuildVersionString()
7374
publisher="unknown"
7475
updateVersionType=None
7576
try:

source/installer.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import easeOfAccess
2222
import COMRegistrationFixes
2323
import winKernel
24+
from typing import Dict
2425

2526
_wsh=None
2627
def _getWSH():
@@ -227,15 +228,15 @@ def removeOldProgramFiles(destPath):
227228
log.warning(f"Couldn't remove file: {path!r}")
228229

229230

230-
uninstallerRegInfo={
231-
"DisplayName":versionInfo.name,
232-
"DisplayVersion":versionInfo.version,
233-
"DisplayIcon":u"{installDir}\\images\\nvda.ico",
234-
"InstallDir":u"{installDir}",
235-
"Publisher":versionInfo.publisher,
236-
"UninstallDirectory":u"{installDir}",
237-
"UninstallString":u"{installDir}\\uninstall.exe",
238-
"URLInfoAbout":versionInfo.url,
231+
uninstallerRegInfo: Dict[str, str] = {
232+
"DisplayName": f"{versionInfo.name} {versionInfo.version}",
233+
"DisplayVersion": versionInfo.version_detailed,
234+
"DisplayIcon": os.path.join(installDir, "images", "nvda.ico"),
235+
"InstallDir": "{installDir}",
236+
"Publisher": versionInfo.publisher,
237+
"UninstallDirectory": "{installDir}",
238+
"UninstallString": os.path.join(installDir, "uninstall.exe"),
239+
"URLInfoAbout": versionInfo.url,
239240
}
240241

241242

source/versionInfo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
aboutMessage = _(
2222
# Translators: "About NVDA" dialog box message
2323
u"""{longName} ({name})
24-
Version: {version}
24+
Version: {version} ({version_detailed})
2525
URL: {url}
2626
{copyright}
2727

0 commit comments

Comments
 (0)