Merge 90518b2 into 05aeb3d

CyrilleB79 · web-flow · commit 4967d080ed78 · 2024-11-13T16:14:52.000Z
diff --git a/source/pythonConsole.py b/source/pythonConsole.py
@@ -29,6 +29,7 @@
 from logHandler import log  # noqa: E402
 import braille  # noqa: E402
 import gui.contextHelp  # noqa: E402
+import textInfos  # noqa: E402
 
 
 class HelpCommand(object):
@@ -223,7 +224,6 @@ def initNamespace(self):
 		import config
 		import controlTypes
 		import globalPlugins
-		import textInfos
 		import vision
 
 		self.namespace.clear()
@@ -255,25 +255,35 @@ def updateNamespaceSnapshotVars(self):
 		Typically, used before the NVDA python console is opened, after which, calls
 		to the 'api' module will refer to this new focus.
 		"""
-		try:
-			caretPos = api.getCaretPosition()
-		except RuntimeError:
-			log.debug("Unable to set caretPos snapshot variable for python console.")
-			caretPos = None
 
-		self._namespaceSnapshotVars = {
-			"focus": api.getFocusObject(),
+		def _getCaretPos() -> textInfos.TextInfo | None:
+			try:
+				return api.getCaretPosition()
+			except RuntimeError:
+				log.debug("Unable to set caretPos snapshot variable for python console.")
+				return None
+
+		self._namespaceSnapshotVarsGetters = {
+			"focus": api.getFocusObject),
 			# Copy the focus ancestor list, as it gets mutated once it is replaced in api.setFocusObject.
-			"focusAnc": list(api.getFocusAncestors()),
-			"fdl": api.getFocusDifferenceLevel(),
-			"fg": api.getForegroundObject(),
-			"nav": api.getNavigatorObject(),
-			"caretObj": api.getCaretObject(),
-			"caretPos": caretPos,
-			"review": api.getReviewPosition(),
-			"mouse": api.getMouseObject(),
-			"brlRegions": braille.handler.buffer.regions,
+			"focusAnc": (lambda: list(api.getFocusAncestors())),
+			"fdl": (lambda: api.getFocusDifferenceLevel()),
+			"fg": (lambda: api.getForegroundObject()),
+			"nav": (lambda: api.getNavigatorObject()),
+			"caretObj": (lambda: api.getCaretObject()),
+			"caretPos": _getCaretPos,
+			"review": (lambda: api.getReviewPosition()),
+			"mouse": (lambda: api.getMouseObject()),
+			"brlRegions": (lambda: braille.handler.buffer.regions),
 		}
+		self._namespaceSnapshotVars = {}
+		for name, getter in self._namespaceSnapshotVarsGetters.items():
+			try:
+				value = getter()
+			except Exception:
+				log.error(f"Unable to set {name} snapshot variable for python console.", exc_info=True)
+				value = None
+			self._namespaceSnapshotVars[name] = value
 		self.namespace.update(self._namespaceSnapshotVars)
 
 	def removeNamespaceSnapshotVars(self):
diff --git a/user_docs/en/changes.md b/user_docs/en/changes.md
@@ -64,6 +64,7 @@ To use this feature, "allow NVDA to control the volume of other applications" mu
 * NVDA will no longer announce Windows 11 clipboard history entries when closing the window while items are present. (#17308, @josephsl)
 * If the plugins are reloaded while a browseable message is opened, NVDA will no longer fail to report subsequent focus moves. (#17323, @CyrilleB79)
 * When using applications such as Skype, Discord, Signal and Phone Link for audio communication, NVDA speech and sounds no longer decrease in volume. (#17349, @jcsteh)
+* Opening the NVDA Python Console will no longer fail in case an error occurs while retrieving snapshot variables.
 
 ### Changes for Developers
 
