Merge 753dbbf into 9329591

michaelDCurran · web-flow · commit 381781adef36 · 2022-11-11T09:32:03.000+10:00
diff --git a/source/appModules/teams.py b/source/appModules/teams.py
@@ -17,11 +17,22 @@ class PopOverMenu(Ia2Web):
 class AppModule(appModuleHandler.AppModule):
 
 	def chooseNVDAObjectOverlayClasses(self, obj, clsList):
+		# #11821, #14355
+		# Teams will sometimes create an element with an ARIA role of menu
+		# at the same time another element gets focus,
+		# E.g. an emoji menu appears every time a conversation message is focused.
+		# Web frameworks such as Chromium will tend to fire a menu_popupStart event
+		# when a node with a role of menu is added to the DOM.
+		# NVDA's default behaviour for handling menu_popupStart is to set NVDA's focus to the menu
+		# and cancel speech.
+		# We should deliberately suppress this in Teams however,
+		# Otherwise the focused message cannot be read.
+		# Previously this was limited to message menus, however
+		# As Teams keeps changing the layout,
+		# and all menus in Teams do set focus to their first item when truly focused,
+		# It is safer just to ignore all menu popupStart events within Teams content for now.
 		if (
 			Ia2Web in clsList
 			and obj.IA2Attributes.get("xml-roles") == "menu"
-			and obj.parent
-			and obj.parent.parent
-			and "message-actions-popover-container" in obj.parent.parent.IA2Attributes.get("class", "")
 		):
 			clsList.insert(0, PopOverMenu)
diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t
@@ -141,6 +141,7 @@ Note there are still known issues with Chrome and Edge. (#13254)
 - NVDA will announce dragging items on screen in places such as rearranging Windows 10 Start menu tiles and virtual desktops in Windows 11. (#12271, #14081)
 - In advanced settings, "Play a sound for logged errors" option is now correctly restored to its default value when pressing the "Restore defaults" button. (#14149)
 - NVDA can now select text using the ``NVDA+f10`` keyboard shortcut on Java applications. (#14163)
+- NVDA will no longer get stuck in a menu when arrowing up and down threaded conversations in Microsoft Teams. (#14355)
 -
 
 

Original file line number	Diff line number	Diff line change
`@@ -141,6 +141,7 @@ Note there are still known issues with Chrome and Edge. (#13254)`
`141`	`141`	`- NVDA will announce dragging items on screen in places such as rearranging Windows 10 Start menu tiles and virtual desktops in Windows 11. (#12271, #14081)`
`142`	`142`	`- In advanced settings, "Play a sound for logged errors" option is now correctly restored to its default value when pressing the "Restore defaults" button. (#14149)`
`143`	`143`	- NVDA can now select text using the ``NVDA+f10`` keyboard shortcut on Java applications. (#14163)
	`144`	`+- NVDA will no longer get stuck in a menu when arrowing up and down threaded conversations in Microsoft Teams. (#14355)`
`144`	`145`	`-`
`145`	`146`
`146`	`147`