This repository was archived by the owner on Apr 17, 2026. It is now read-only.
Update pot build command as per the one in NVDA's repo (update in PR NVDA/#15013)#106
Merged
Merged
Conversation
seanbudd
reviewed
Jun 26, 2023
Member
|
All test steps appear successful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Today, the first version of NVDA including nvaccess/nvda#15013 has been merged to SVN. The translatable strings using
ngettextappear in thenvda.poas expected. But the strings usingnpgettext("%.1f lignes") don't.Cause
In PR nvaccess/nvda#15013, the command to build the .pot file has been updated to be able to recognize
npgettextas a function operating on translatable strings.However, the nvda2svn script in the current repository does not use the .pot generated by NVDA's
sconstruct; xgettext is called directly in the current repository instead. Thus the command in the nvda2svn script should match the one in NVDA's sconstruct. The change in NVDA's repository had not been duplicated here.Solution
Update
xgettext's parameters as per what was done in NVDA's repo to be able to detectngettextas a function operating on translatable strings.Testing
I have no way to test before merging this PR.
@seanbudd, could you test manually this branch on NVAccess server the result of nvda2svn script or merge this PR and trigger nvda2svn?