Skip to content
This repository was archived by the owner on Feb 28, 2023. It is now read-only.

Add new add-on: enhancedAnnotations#392

Merged
feerrenrut merged 2 commits into
nvaccess:masterfrom
nvdaes:enhancedAnnotations-1.0
Aug 30, 2022
Merged

Add new add-on: enhancedAnnotations#392
feerrenrut merged 2 commits into
nvaccess:masterfrom
nvdaes:enhancedAnnotations-1.0

Conversation

@nvdaes

@nvdaes nvdaes commented Jul 27, 2022

Copy link
Copy Markdown
Collaborator

Release information

Changelog (mention changes in separate lines starting with dash space)

  • Initial version

Additional information

This add-on has been reviewed by @ruifontes , and previous version of its plugins were shared privately with DAISY Consortium members and tested by @GeorgeKerscher
When this is included on the website, I'll include the download link.
add-on review on the mailing list

Enhanced Annotations

  • Authors: George Kerscher, Noelia Ruiz Martínez
  • (compatible with NVDA 2022.1 and beyond)

In the DAISY Consortium, best practices are developed for publishers and authors for providing extended (long) descriptions.

The best practices use the HTML details element that follows the image, or a link to another file that contains the extended description.

In both options, the user would need to move to the details or the link and activate it.

Having a keystroke to put focus on the details or the link is ideal.

Our best practices recommend that the details or the link immediately follows the image, and if the link is followed, a back link to the exact location must be provided. This makes it certain that the user will not get lost.

However it is probable that authors in the wild will place the extended (long) description almost anywhere. In these cases, the user would want to return to the image and hence the need for a way to return to the original image.

This add-on provides both features, in support of this issue opened in NVDA's repository.

Commands

  • NVDA+alt+d: moves the cursor to the element identified with aria-details.
  • NVDA+alt+shift+d: moves the cursor to the original element, for example, an image with furter details like a long description.

The above commands can be modified from NVDA's menu, Preferences submenu, Input gestures dialog, Browse mode category.

@josephsl josephsl self-requested a review July 27, 2022 12:56
@ruifontes

Copy link
Copy Markdown
Contributor

I don't agree...
As I said in my review, there are some messages not possible to translate! They have messages for translators, they have the code for getText, but it was not created a .pot file neither the locale folder...

The 3 messages are:

description=("Navigates to the details of the current position in browse mode"),
description=
("After navigating to additional details, moves back to the original position in browse mode"),
ui.message(_("No element with additional details to go back"))

@nvdaes

nvdaes commented Jul 28, 2022 via email

Copy link
Copy Markdown
Collaborator Author

@feerrenrut feerrenrut merged commit 0338b68 into nvaccess:master Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants