Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

Add missing NVDA minor versions#24

Merged
seanbudd merged 1 commit into
nvaccess:mainfrom
CyrilleB79:allVersions
Dec 10, 2023
Merged

Add missing NVDA minor versions#24
seanbudd merged 1 commit into
nvaccess:mainfrom
CyrilleB79:allVersions

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Found while reviewing nvaccess/nvda#15888

Issue

NVDA API version json file does not cover all existing NVDA versions. These ones minor versions are missing:

  • 2018.4.1
  • 2019.1.1
  • 2019.2.1
  • 2019.3.1

I doubt any add-on is impacted by these missing minor versions. But for completeness and clarity, it's better to have them covered.

Solution

  • Fix the description of API 0.0.0 so that 2018.4.1 is covered
  • Added API for 2019.1.1 and 2019.2.1
  • Fixed description of 2019.3 to include also 2019.3.1. No API is added for this version since it contains only new translations; it is worth noting that this version is not listed in NVDA's change log.

@seanbudd

Copy link
Copy Markdown
Member

sorry my mistake, misread the description / diff

@seanbudd seanbudd merged commit fdf669c into nvaccess:main Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants