Skip to content

Merge virus total support#3765

Merged
seanbudd merged 3 commits into
masterfrom
master
Jun 11, 2024
Merged

Merge virus total support#3765
seanbudd merged 3 commits into
masterfrom
master

Conversation

@seanbudd

Copy link
Copy Markdown
Member

Merge PR: nvaccess#61
Closes #3246

Fixes issue nvaccess#3246

Summary of the issue
VirusTotal may catch malware bundled with add-ons.
Also, knowing the sha256 of scanned add-ons, the URL to see results at different datetimes maybe built, allowing users to see this information even before installing an add-on if this was included in the NVDA store in the future.

Development strategy
Virus Total CLI is installed when needed.
Add-ons are scanned when the submission issue is created.
Info about the add-on file is requested to Virus Total later, when the pull request is created, to give time to Virus Total to show results, trying to avoid getting empty analysis.
NV Access needs to create an API key in Virus Total.
The addonMetadata.json artifact is used to get the add-on id and sha256.
A falsePositiveAddons.json file has been added. If VirusTotal analysis fails, a pull request will be created adding the sha256 of the addon to a list associated with the add-on ID, in the falsePositiveAddons.json file.
If VirusTotal should be skipped for this add-on, NV Access will merge the created pull request, delete the branch created for the submission (in the form submitterIssueNumber), and relabel the issue to trigger a new workflow.

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix references to api key

Comment thread .github/workflows/virusTotalAnalysis.js Outdated
Comment thread .github/workflows/checkAndSubmitAddonMetadata.yml Outdated
Comment thread .github/workflows/sendJsonFile.yml Outdated
Comment thread .github/workflows/sendJsonFile.yml Outdated
Comment thread .github/workflows/checkAndSubmitAddonMetadata.yml Outdated
Comment thread .github/workflows/sendJsonFile.yml Outdated
@seanbudd seanbudd merged commit 1b11f46 into nvaccess:master Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the VirusTotal API to scan submitted add-ons for malicious content

2 participants