Skip to content

feat(merger): add to exports#922

Merged
ineshbose merged 7 commits intomainfrom
chore/move-merger
Dec 16, 2024
Merged

feat(merger): add to exports#922
ineshbose merged 7 commits intomainfrom
chore/move-merger

Conversation

@ineshbose
Copy link
Copy Markdown
Collaborator

@ineshbose ineshbose commented Nov 27, 2024

🔗 Linked issue

resolves #915
should also resolve #927

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Play: https://stackblitz.com/github/nuxt-modules/tailwindcss/tree/chore/move-merger

@ineshbose ineshbose changed the title chore(merger): add to exports feat(merger): add to exports Nov 27, 2024
@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Nov 27, 2024

PR Summary

  • Enhanced Package Configuration

    • The package file (package.json) has been updated to include a new entry and some modifications that contain updates like paths and definitions related to a new merger module. This enables better module management within the code.
  • Streamlined Internal Context Load File

    • Adjustments have been made on how certain functionalities are imported and used in the 'load.ts' file. Import paths have been reorganized, and redundant arguments in function calls have been eliminated, making the code much cleaner.
  • Upgraded Code File with TypeScript

    • The merger.js file has been rewritten using TypeScript (into merger.ts), adding type definitions for more robust, error-proof code. TypeScript’s strict syntactical features provide an extra layer of protection by catching errors during the build phase itself.
  • Simplified Module Function Call

    • A call to the generateConfig function in the 'module.ts' file has been simplified by removing extraneous parameters. This makes the code easier to understand and less complex to maintain.

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 27, 2024

Deploy Preview for nuxt-tailwindcss ready!

Name Link
🔨 Latest commit 08e0cdf
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-tailwindcss/deploys/67605193f1648d000856c991
😎 Deploy Preview https://deploy-preview-922--nuxt-tailwindcss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ineshbose
Copy link
Copy Markdown
Collaborator Author

Not likely a solution. Will revisit this. Closing this PR for now.

@ineshbose ineshbose closed this Dec 6, 2024
@ineshbose ineshbose deleted the chore/move-merger branch December 6, 2024 19:26
@ineshbose ineshbose restored the chore/move-merger branch December 13, 2024 19:04
@ineshbose ineshbose reopened this Dec 13, 2024
@ineshbose ineshbose merged commit 67a730c into main Dec 16, 2024
@ineshbose ineshbose deleted the chore/move-merger branch December 25, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ERROR ExperimentalWarning: CommonJS module is loading ES Module Move runtime merger.js to relative path

2 participants