Conversation
…r-m75h) Query params not matching known OG image options were passed as component props to the Nuxt island renderer. Vue's fallthrough attributes then rendered them as HTML attributes on the root element, enabling injection of event handlers like onmouseover.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves GHSA-mg36-wvcr-m75h
❓ Type of change
📚 Description
Query params not matching known OG image options (
width,height,component, etc.) were forwarded as component props to the Nuxt island renderer. Vue's fallthrough attributes then rendered unknown props as HTML attributes on the root element, enabling injection of event handlers (onmouseover,onclick) and dangerous attributes (autofocus).Adds
sanitizeProps()which stripson*event handlers and dangerous HTML attributes (autofocus,contenteditable,tabindex,accesskey) from props before they reach the island renderer. Includes unit tests.