Skip to content

fix: cast title meta as string in CldOgImage#178

Merged
Baroshem merged 1 commit intonuxt-modules:mainfrom
huang-julien:fix/cldogimagetpyes
Jan 8, 2024
Merged

fix: cast title meta as string in CldOgImage#178
Baroshem merged 1 commit intonuxt-modules:mainfrom
huang-julien:fix/cldogimagetpyes

Conversation

@huang-julien
Copy link
Contributor

@huang-julien huang-julien commented Jan 3, 2024

resolve #177

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Hi 👋 This PR fix CldOgImage types for vue-tsc. Since route.meta.title is unknown, ts will assume that computedTwitterTitle is ComputedRef<{}> instead of ComputedRef<string>

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@netlify
Copy link

netlify bot commented Jan 3, 2024

‼️ Deploy request for nuxt-cloudinary-module rejected.

Name Link
🔨 Latest commit 75f823f

@Baroshem Baroshem merged commit f71030c into nuxt-modules:main Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CldOgImage breaks typecheck

2 participants