fix(blob): avoid @vercel/blob build breakage#860
Open
onmax wants to merge 1 commit intonuxt-hub:mainfrom
Open
Conversation
|
@onmax is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
a6dec4c to
92e2796
Compare
commit: |
92e2796 to
7f36864
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #859
Summary
@vercel/blob/clientimport path fromuseMultipartUpload@vercel/blob is required to use useMultipartUpload with Vercel Blobpnpm add @vercel/blobmodule present,module missing,missing upload export)Reproduction (Cloudflare-oriented)
Baseline repro app (
@nuxthub/core@0.10.7,hub.blob: true,nitro.preset: 'cloudflare_module',useMultipartUploadreferenced, no@vercel/blob):Before this fix:
Rollup failed to resolve import "@vercel/blob/client"fromuseMultipartUpload.mjsAfter this fix (installing this patched package into the same repro app):
pnpm nuxt buildcompletes successfullyTests
pnpm eslint src/blob/runtime/app/composables/useMultipartUpload.ts test/useMultipartUpload.vercel.test.tspnpm vitest test/useMultipartUpload.vercel.test.tspnpm vitest test/blob.test.ts@vercel/blob