Skip to content

fix: merge highlight options with defu #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
farnabaz merged 1 commit into from
Sep 9, 2025
Merged

fix: merge highlight options with defu #409

farnabaz merged 1 commit into from
Sep 9, 2025

Conversation

@farnabaz
Copy link
Collaborator

@farnabaz farnabaz commented Aug 13, 2025

🔗 Linked issue

reported in nuxt/content#3502

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

@nuxthub-admin
Copy link
Contributor

nuxthub-admin bot commented Aug 13, 2025 •
edited
Loading

✅ Deployed mdc

Deployed mdc a38bc36 to preview

🔗 fix-highlight-defaults.mdc-btm.pages.dev
📌 7134057b.mdc-btm.pages.dev
📱
View QR Code QR code linking to deployment URL.

📋 View deployment logs

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 13, 2025 

npm i https://pkg.pr.new/@nuxtjs/mdc@409

commit: a38bc36

@farnabaz farnabaz mentioned this pull request Aug 13, 2025
Closed
@AnOrdinaryPeople
Copy link

AnOrdinaryPeople commented Aug 14, 2025

Hi @farnabaz
The PR doesn’t resolve the issue in my setup. I’ve pushed a reproduction repo with the updated dependency version, the problem still persists. Could you take a look?

@farnabaz
Copy link
Collaborator Author

farnabaz commented Sep 5, 2025

@AnOrdinaryPeople Just checked your reproductions.

Could you try:

  • Move mdc module to resolutions
  "resolutions": {
    "@nuxtjs/mdc": "https://pkg.pr.new/@nuxtjs/mdc@409"
  },
  • remove node_module and bun.lock
  • Install again

AnOrdinaryPeople
AnOrdinaryPeople approved these changes Sep 6, 2025
View reviewed changes
Copy link

@AnOrdinaryPeople AnOrdinaryPeople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the guide! I tested it in both the Bun and Node.js runtimes, and they both worked as expected 👍

@farnabaz farnabaz merged commit babd9f1 into main Sep 9, 2025
3 checks passed
@AnOrdinaryPeople AnOrdinaryPeople mentioned this pull request Sep 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AnOrdinaryPeople AnOrdinaryPeople AnOrdinaryPeople approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@farnabaz @AnOrdinaryPeople