Skip to content

fix: config merging order on the server side#568

Merged
rchl merged 1 commit intomainfrom
fix/server-config-merging
May 10, 2023
Merged

fix: config merging order on the server side#568
rchl merged 1 commit intomainfrom
fix/server-config-merging

Conversation

@rchl
Copy link
Copy Markdown
Member

@rchl rchl commented May 10, 2023

With defu the leftmost arguments have priority. The code did merging backwards due to it using a different library in the past that had opposite logic.

Fixes #567

@github-actions
Copy link
Copy Markdown

size-limit report 📦

Path Size
fixture: base 365.57 KB (0%)
fixture: lazy 370 KB (0%)
fixture: tracing 382.33 KB (0%)
fixture: lazy+tracing 386.72 KB (0%)

@rchl rchl merged commit 4fc42dd into main May 10, 2023
@rchl rchl deleted the fix/server-config-merging branch May 10, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

serverConfig doesn't replace dsn

1 participant