Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
import * as Sentry from '~@sentry/vue'has prevented tree shaking from working.This results in about 221KB reduction when using
tracingand a bit less when not usingtracing(that's weird, yes, but looks like related to Sentry SDK itself).Unfortunately it doesn't benefit when using
lazyloading. Maybe there is a way to handle it using webpack's magic comments insentry-module/src/templates/plugin.lazy.js
Line 112 in 994f333
EDIT: There is a webpack magic comment
webpackExportsbut it's only available from webpack 5.