fix(utilities): avoid send xxx=undefined in query (#387)

bluelovers · pi0 · commit 7c79fd4284ea · 2019-06-24T21:42:39.000+04:30
diff --git a/lib/core/utilities.js b/lib/core/utilities.js
@@ -17,10 +17,11 @@ export const parseQuery = queryString => {
 }
 
 export const encodeQuery = queryObject => {
-  return Object.keys(queryObject)
+  return Object.entries(queryObject)
+    .filter(([key, value]) => typeof value !== 'undefined')
     .map(
-      key =>
-        encodeURIComponent(key) + '=' + encodeURIComponent(queryObject[key])
+      ([key, value]) =>
+        encodeURIComponent(key) + (value != null ? '=' + encodeURIComponent(value) : '')
     )
     .join('&')
 }

Original file line number	Diff line number	Diff line change
`@@ -17,10 +17,11 @@ export const parseQuery = queryString => {`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`export const encodeQuery = queryObject => {`
`20`		`- return Object.keys(queryObject)`
	`20`	`+ return Object.entries(queryObject)`
	`21`	`+ .filter(([key, value]) => typeof value !== 'undefined')`
`21`	`22`	`.map(`
`22`		`- key =>`
`23`		`- encodeURIComponent(key) + '=' + encodeURIComponent(queryObject[key])`
	`23`	`+ ([key, value]) =>`
	`24`	`+ encodeURIComponent(key) + (value != null ? '=' + encodeURIComponent(value) : '')`
`24`	`25`	`)`
`25`	`26`	`.join('&')`
`26`	`27`	`}`