Skip to content

feat(module)!: migrate to reka-ui#2448

Merged
benjamincanac merged 76 commits intov3from
feat/reka-ui
Dec 3, 2024
Merged

feat(module)!: migrate to reka-ui#2448
benjamincanac merged 76 commits intov3from
feat/reka-ui

Conversation

@benjamincanac
Copy link
Member

@benjamincanac benjamincanac commented Oct 24, 2024 •
edited
Loading

🔗 Linked issue

Resolves #2259, fixes #2133, fixes #2134, fixes #2350, fixes #2742, fixes #2730.

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

With the migration to Reka UI, a few breaking changes are introduced:

Checkbox

  • The indeterminate prop has been removed in favor of v-model / default-value: boolean | "indeterminate"

CommandPalette

  • The filter field on groups has been renamed to ignoreFilter for consistency

InputMenu/SelectMenu

  • The filter prop has been removed in favor of ignore-filter & filter-fields
  • The create-item prop no longer assign to v-model to provide more flexibility when working with objects. You have to do it yourself in the @create event which now receive only the typed string as argument.

Tabs

  • The content of inactive items is no longer rendered when unmounted by default, use :unmount-on-hide="false" to get the same result

You can read the Reka UI migration guide if you're interested: https://reka-ui.com/docs/guides/migration#form-component although most of the changes have been done internally.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 24, 2024 •
edited
Loading

Deploying ui3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: b92eae7
Status: ✅  Deploy successful!
Preview URL: https://0e684fd7.ui-6q2.pages.dev
Branch Preview URL: https://feat-reka-ui.ui-6q2.pages.dev

View logs

@benjamincanac benjamincanac added the v3 #1289 label Oct 24, 2024
@benjamincanac benjamincanac changed the title feat(module): migrate to reka-ui feat(module)!: migrate to reka-ui Oct 24, 2024
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 19, 2024 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@2448

commit: b92eae7

@MickL
Copy link
Contributor

MickL commented Dec 2, 2024

@benjamincanac I just wanted to try Nuxt UI 3 for the first time but I wanted to use it with Reka UI. Im trying if I can use this PR as a dependency.

@benjamincanac
Copy link
Member Author

benjamincanac commented Dec 2, 2024

I'm still working on this but yes you can install it through pkg.pr.new!

@MickL
Copy link
Contributor

MickL commented Dec 2, 2024

I just noticed when reading the docs, very cool! :)

It is written here, command to get this PR:

bun add https://pkg.pr.new/@nuxt/ui@2448

@MickL
Copy link
Contributor

MickL commented Dec 2, 2024 •
edited
Loading

I am getting

 ERROR  Internal server error: [postcss] postcss-import: /Users/mick/git/my-project/node_modules/tailwindcss/lib/index.js:1:1: Unknown word
  Plugin: vite:css

File: /Users/mick/git/my-project/node_modules/tailwindcss/lib/index.js:1:0
  1  |  "use strict";
     |  ^
  2  |  module.exports = require("./plugin");

Within a fresh new Nuxt project, just by having @import "tailwindcss"; in the main.css. The same goes for alpha.9

If I dont do step 3 from the docs (not adding css file with imports) it seems to work as expected:

https://ui3.nuxt.dev/getting-started/installation/nuxt#import-tailwind-css-and-nuxt-ui-in-your-css

@benjamincanac
Copy link
Member Author

benjamincanac commented Dec 2, 2024

@MickL Please open a new issue with a reproduction for this.

@benjamincanac benjamincanac marked this pull request as ready for review December 2, 2024 16:55
@benjamincanac benjamincanac merged commit 81ac076 into v3 Dec 3, 2024
@benjamincanac benjamincanac deleted the feat/reka-ui branch December 3, 2024 15:11
@benjamincanac benjamincanac restored the feat/reka-ui branch December 3, 2024 15:12
@benjamincanac benjamincanac deleted the feat/reka-ui branch December 3, 2024 15:12
@benjamincanac benjamincanac mentioned this pull request Dec 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

v3 #1289

Projects

None yet

Milestone

No milestone

2 participants

@benjamincanac @MickL