Skip to content

chore: use tinyexec#939

Merged
danielroe merged 2 commits intonuxt:mainfrom
BobbieGoede:chore/tinyexec
Sep 10, 2024
Merged

chore: use tinyexec#939
danielroe merged 2 commits intonuxt:mainfrom
BobbieGoede:chore/tinyexec

Conversation

@BobbieGoede
Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Same as nuxt/nuxt#28684

Tried tinyexec in the test-utils 'fork' used in the i18n module, besides reducing dependencies it seems to perform better than execa when running with CI=1 (based on very basic & lazy testing).

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 10, 2024
@BobbieGoede
Copy link
Copy Markdown
Member Author

I also raised the timeouts for windows browser tests, while it may be slower at least we can be sure that the tests succeed.

Copy link
Copy Markdown
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ⚡

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 10, 2024
@danielroe danielroe merged commit 4bd549f into nuxt:main Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants