feat: expose goto() fixture with hydration features#781
Merged
danielroe merged 1 commit intonuxt:feat/playwright-runnerfrom Mar 15, 2024
Merged
Conversation
bf4efbd to
574ef20
Compare
danielroe
reviewed
Mar 15, 2024
| test('test', async ({ page }) => { | ||
| await page.goto('/') | ||
| test('test', async ({ page, goto }) => { | ||
| await goto('/', { waitUntil: 'hydration' }) |
Member
There was a problem hiding this comment.
would this behaviour also work with page.goto?
Collaborator
Author
There was a problem hiding this comment.
Unfortunately not, we don't recommend overriding page.goto so I think exposing it as a fixture is a nice middle-line between both sides (overriding class vs. making this extra functionality available).
danielroe
approved these changes
Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.