Skip to content

feat(webpack): Expose webpack base config class#5425

Closed
juliendargelos wants to merge 2 commits intonuxt:devfrom
juliendargelos:patch-1
Closed

feat(webpack): Expose webpack base config class#5425
juliendargelos wants to merge 2 commits intonuxt:devfrom
juliendargelos:patch-1

Conversation

@juliendargelos
Copy link
Copy Markdown

Expose webpack base config class.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Add an export of the WebpackBaseConfig class.

It could be useful for some advanced modules to be able to extend this class for independent webpack build using Nuxt base config:
I'm making a module which hooks Nuxt to add another webpack build with NetlifyCMS, but sharing some source files with Nuxt project (for previews). I would like to have the same base configuration so Nuxt project files can be imported with the same rules, plugins, etc...

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #5425 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5425   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          74       74           
  Lines        2555     2555           
  Branches      652      652           
=======================================
  Hits         2457     2457           
  Misses         82       82           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 159123f...c920678. Read the comment docs.

@juliendargelos juliendargelos changed the title feat(webpack) Expose webpack base config class feat(webpack): Expose webpack base config class Mar 30, 2019
@TheAlexLichter
Copy link
Copy Markdown
Member

Thanks for the PR!
We had a similar one at #5366 which has evolved to #5378 so far ☺️

I'd suggest to bring in your ideas and concerns there or create a more in-depth PR if the suggested changes are too different.

@pi0
Copy link
Copy Markdown
Member

pi0 commented Mar 31, 2019

Thanks, @juliendargelos for this PR. I'm closing this to move to discuss in #5378.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants