Skip to content

fix(vue-app): enable dynamic publicPath on server-side#8759

Merged
pi0 merged 10 commits intodevfrom
8662-dynamic-public-path-on-server
Feb 4, 2021
Merged

fix(vue-app): enable dynamic publicPath on server-side#8759
pi0 merged 10 commits intodevfrom
8662-dynamic-public-path-on-server

Conversation

@danielroe
Copy link
Copy Markdown
Member

@danielroe danielroe commented Feb 3, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

closes #8662

Checklist:

  • I have added tests to cover my changes
  • All new and existing tests are passing. - note - not sure why tests failed earlier

Comment thread test/dev/basic.dynamic.test.js
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 3, 2021

Codecov Report

Merging #8759 (69ce0ce) into dev (07dd2cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #8759   +/-   ##
=======================================
  Coverage   66.03%   66.03%           
=======================================
  Files          92       92           
  Lines        4013     4013           
  Branches     1105     1105           
=======================================
  Hits         2650     2650           
  Misses       1097     1097           
  Partials      266      266           
Flag Coverage Δ
unittests 66.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07dd2cc...69ce0ce. Read the comment docs.

@danielroe danielroe marked this pull request as ready for review February 3, 2021 21:00
Comment thread packages/vue-app/template/server.js Outdated
@pi0 pi0 merged commit 1196c17 into dev Feb 4, 2021
@pi0 pi0 deleted the 8662-dynamic-public-path-on-server branch February 4, 2021 20:56
@pi0 pi0 mentioned this pull request Feb 9, 2021
Copy link
Copy Markdown

@hippiechick60 hippiechick60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dynamic publicPath not working with img tags and assets within css (unless extractCSS: true)

4 participants