Skip to content

fix(webpack): chunk name normalization for catch-all pages and windows#7603

Merged
pi0 merged 4 commits intodevfrom
fix-catch-all-chunk-not-found
Jun 24, 2020
Merged

fix(webpack): chunk name normalization for catch-all pages and windows#7603
pi0 merged 4 commits intodevfrom
fix-catch-all-chunk-not-found

Conversation

@aldarund
Copy link
Copy Markdown
Contributor

@aldarund aldarund commented Jun 24, 2020 •
edited
Loading

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

For _.vue SplitChunks will generate route starting with dot and it will lead to 404 for this chunks
Dropped window path replace to be in line with Linux, as seems to work fine on win without it

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 changed the title fix: catch all route chunk not found fix(webpack): chunk name normalization for catch-all pages and windows Jun 24, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 24, 2020 •
edited
Loading

Codecov Report

Merging #7603 into dev will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7603      +/-   ##
==========================================
+ Coverage   70.26%   70.28%   +0.01%     
==========================================
  Files          88       88              
  Lines        3747     3745       -2     
  Branches     1020     1019       -1     
==========================================
- Hits         2633     2632       -1     
+ Misses        905      904       -1     
  Partials      209      209
Flag Coverage Δ
#unittests 70.28% <100.00%> (+0.01%) ⬆️
Impacted Files Coverage Δ
packages/utils/src/resolve.js 98.11% <100.00%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56b158e...83e7808. Read the comment docs.

@pi0
Copy link
Copy Markdown
Member

pi0 commented Jun 24, 2020

Seems windows tests need updating: https://dev.azure.com/nuxt/nuxt.js/_build/results?buildId=7762&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=bd05475d-acb5-5619-3ccb-c46842dbc997&l=109

@aldarund aldarund requested a review from pi0 June 24, 2020 20:38
@pi0 pi0 merged commit d89812f into dev Jun 24, 2020
@pi0 pi0 deleted the fix-catch-all-chunk-not-found branch June 25, 2020 09:39
This was referenced Jun 26, 2020
Merged
Merged
@cmorbitzer cmorbitzer mentioned this pull request Jun 29, 2020
Closed
@aaronhuisinga
Copy link
Copy Markdown

aaronhuisinga commented Jun 29, 2020

@aldarund @pi0 This introduced a regression breaking dynamic routing in AWS API Gateway and likely many other services. According to RFC3986, square brackets are not valid in URIs, and several services don't allow them. API Gateway will return a 400 with any request containing them, as an example (that we're currently running into).

@pi0 pi0 mentioned this pull request Jun 30, 2020
Merged
7 tasks
@pi0 pi0 mentioned this pull request Jul 29, 2020
Merged
7 tasks
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

No one assigned

Labels

2.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aldarund @codecov-commenter @pi0 @aaronhuisinga @danielroe