feat(nuxt): use AbortSignal to abort asyncData
#32918
Conversation
|
|
|
I think we still need to cancel previous promise (if still running) with the last signal 👀 |
I will add this. Maybe you could share your thoughts on how we should propagate this error: (+ this should be |
Isnt this done here? |
|
With the current implementation, the status is |
I have not found a clean solution yet. I will check again tomorrow. 😄 |
execute()
// status.value -> pending
execute()
// status.value -> pending
execute()
// status.value -> pending
// status.value -> success
execute()
// status.value -> pending
clear()
// status.value -> idle + requets aborted
const ac = new AbortController()
execute({signal: ac.signal})
// status.value -> pending
ac.abort(new WhatEverError())
// status.value -> error
execute({timeout: 10})
// status.value -> pending
// status.value -> error |
|
ToDos:
|
🔗 Linked issue
📚 Description
Based on @huang-julien #32531 - swapping exposed AbortController for exposed AbortSignal + adding timeout to asyncData.
Opening this as PR to better discuss some of the POC changes.