perf(kit): avoid duplicate join operation#24717
Merged
Conversation
|
|
danielroe
reviewed
Dec 13, 2023
join operation
danielroe
approved these changes
Dec 13, 2023
8 tasks
Merged
9 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#24707
❓ Type of change
📚 Description
There is a duplicate filesystem operation in the nuxt module resolving process. This PR saves the reference to prevent the redundancy and thereby improve the performance.
NOTE: While the performance improvement here is way more miniscule, it still exists. I couldn't test it with the methods nuxt uses (I will make a benchmark with that soon) but with native fs's methods there's a ~10ms decrease in execution time, which is much more noticeable is longer iterations (~8.38% performance increase in 1000 iterations):
I don't know if pathe implements it differently, so I don't mind this not being merged for the time being (until I make the tests), however even my mind tells me a duplicate operation, even if insanely fast, will still take longer than saving a reference to it.
📝 Checklist