perf(nuxt): use granular watcher to avoid crawling ignored dirs#20836
Merged
perf(nuxt): use granular watcher to avoid crawling ignored dirs#20836
Conversation
Member
Author
|
/trigger release |
Contributor
|
🚀 Release triggered! You can now install nuxt@npm:nuxt3@pr-20836 |
1 similar comment
Contributor
|
🚀 Release triggered! You can now install nuxt@npm:nuxt3@pr-20836 |
Member
Author
|
/trigger release |
Contributor
|
🚀 Release triggered! You can now install nuxt@npm:nuxt3@pr-20836 |
antfu
reviewed
May 18, 2023
antfu
approved these changes
May 18, 2023
Member
antfu
left a comment
There was a problem hiding this comment.
Amazing idea! Love the approach!
atinux
approved these changes
May 18, 2023
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#12376
❓ Type of change
📚 Description
This follows up previous focus on watcher improvements (#20179) as a hybrid solution using
chokidar- it filters out/ignores child directories withinsrcDirdirectly. In tests in the monorepo, it reduces chokdar startup on a M1 Mac by 50%. I would expect even more significant performance improvements on a windows machine.To enable this you'll need to set
experimental.watchertogranular. (Otherwise behaviour will stay the same as currently.)I'd appreciate review - my main concern is whether we ought to make provision for users deliberately seeking to watch changes in
.nuxtornode_modules(which they have enabled with a negative glob pattern inignore).cc: @stafyniaksacha
📝 Checklist