refactor(config,vue-app): change back to app namespace#10197
Closed
refactor(config,vue-app): change back to app namespace#10197
Conversation
* for parity with Nuxt 3 * also migrate `assetsPath` -> `buildAssetsPath`
7 tasks
7 tasks
Codecov Report
@@ Coverage Diff @@
## dev #10197 +/- ##
=======================================
Coverage 65.15% 65.15%
=======================================
Files 94 94
Lines 4155 4156 +1
Branches 1172 1172
=======================================
+ Hits 2707 2708 +1
Misses 1169 1169
Partials 279 279
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
For parity with Nuxt 3, this changes the names (but not the behaviour) of
app.assetsPath->app.buildAssetsPathandpublicRuntimeConfig._app->publicRuntimeConfig.app.Nuxt should merge the app config with any existing properties in
publicRuntimeConfig.appto minimise the impact, but still this should be recognised as a breaking change.Checklist: