fix: ensure deterministic icon sort order in client bundle#446
Merged
fix: ensure deterministic icon sort order in client bundle#446
Conversation
Sort icons alphabetically within each collection to ensure idempotent output regardless of discovery order
antfu
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort icons alphabetically within each collection to ensure idempotent output regardless of discovery order
🔗 Linked issue
Resolves #445
❓ Type of change
📚 Description
I'd like to cache the client bundle but currently it easily changes between runs when using a config like:
It's because the order of the keys in each collection's "icons" object is not consistent.