Skip to content

fix: import server utils from #imports#249

Merged
antfu merged 4 commits intomainfrom
fix/nitro-import
Sep 3, 2024
Merged

fix: import server utils from #imports#249
antfu merged 4 commits intomainfrom
fix/nitro-import

Conversation

@pi0
Copy link
Copy Markdown
Member

@pi0 pi0 commented Sep 3, 2024

Resolves #204 (tested against reproduction in #204 (comment)).

When having multiple versions of nitropack installed (reproduction above has one in the playground and one in top level) for some reason rollup keeps nitropack/runtime as an external although it shouldn't be. this needs more upstream investigation later)

Using #imports seems to fix the issue as it aliases to the explicit path.

@antfu antfu changed the title fix: import server utils from `#imports fix: import server utils from #imports Sep 3, 2024
@antfu antfu merged commit 76b9ec4 into main Sep 3, 2024
@antfu antfu deleted the fix/nitro-import branch September 3, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package import specifier "#internal/nitro/virtual/app-config" is not defined

2 participants