This repository was archived by the owner on Apr 6, 2023. It is now read-only.
Closed
Conversation
|
✔️ Deploy Preview for nuxt3-docs canceled. 🔨 Explore the source changes: 0167964 🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/61a8ad8ac715e0000815e973 |
pi0
reviewed
Dec 1, 2021
pi0
reviewed
Dec 1, 2021
Contributor
|
Hi, may i ask the progress of this PR ? It's so helpful for me , Thanks 😊 |
|
anything update? |
7 tasks
Member
|
Closing in the favor of #2655 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#12612
resolves nuxt/nuxt#12922
❓ Type of change
📚 Description
cdnURLwasn't being taken into account by bundle-renderer. In addition, when serving static files from/we were never allowing a fallback to rendering the vue app. I don't think it's safe simply to disableserveStaticwhen a CDN is in use, but I would certainly suggest to users that they disable serving static files when using a CDN that does not rely on 'pulling' files from their site:Note: We didn't reserve
.appnamespace in Nuxt 2 (see nuxt/nuxt#9075) in case it's in use so we need to check._appexistence first.📝 Checklist