This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(vite): don't copy publicDir files to _nuxt#2135
Merged
Conversation
|
✔️ Deploy Preview for nuxt3-docs canceled. 🔨 Explore the source changes: 02ae04a 🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/619e5d5d71c4600008bfe260 |
pi0
reviewed
Nov 24, 2021
pi0
approved these changes
Nov 24, 2021
This was referenced Jan 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#12178
❓ Type of change
📚 Description
When building, vite copies
publicDircontents and places them alongside assets in the_nuxtfolder. This is an unwanted duplication of assets. (They will never be served from this path.) We can 'fix' this behaviour by simply not copying these files across to.output/public.Ideally we would fix this with a PR to vite itself to allow us to allow js files to be included with
assetsDiras well, rather than setting vite'sbase: '_nuxt', which seems like a workaround for our desired nuxt behaviour. (cc: @antfu)📝 Checklist