This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(vite): external modules under/esm/ pattern#1949
Merged
Conversation
Co-authored-by: Ben <bencodezen@users.noreply.github.com>
|
✔️ Deploy Preview for nuxt3-docs canceled. 🔨 Explore the source changes: c8a3030 🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/6193a98b19e19b00082b0538 |
pi0
reviewed
Nov 16, 2021
Member
|
Also made unjs/mlly#23 to resolve for mlly/externality |
Co-authored-by: pooya parsa <pyapar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Ben bencodezen@users.noreply.github.com
🔗 Linked issue
❓ Type of change
📚 Description
Found during pairing with @bencodezen 🙌
To reproduce the bug (Vite):
which will cause the error of
exportis not a valid syntax. Searching down, the root cause is that the internal module ofdate-fnsbeen externalized but in a.jsformat of ESM inserver.mjsThis PR adds the conversion to externalize modules under
/esm/which I believe is a common pattern (date-fnsis using is at least).https://unpkg.com/browse/date-fns@2.25.0/esm/_lib/protectedTokens/index.js
📝 Checklist