perf: replace internal object records with maps#3591
Merged
Conversation
|
@OrbisK is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
Member
|
Thanks for the PR, It would be great if we can have a benchmark two decide between them. |
farnabaz
approved these changes
Nov 6, 2025
Member
farnabaz
left a comment
There was a problem hiding this comment.
I ran a small test on Map and Object and the result was almost same with small data.
Beside performance using map is better for security and readability.
Thanks for PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
I was actually looking for other things and came across these improvements. In some places, you could certainly use a map instead of an object record, but that would then affect some exported APIs.
📝 Checklist