add code example for abs download stream

maorfr · maorfr · commit b29ab40292c2 · 2018-12-04T15:27:18.000+02:00
diff --git a/pkg/skbn/abs.go b/pkg/skbn/abs.go
@@ -13,6 +13,7 @@ import (
 
 	"github.com/Azure/azure-pipeline-go/pipeline"
 	"github.com/Azure/azure-storage-blob-go/azblob"
+	// "github.com/Azure/azure-sdk-for-go/storage"
 )
 
 var err error
@@ -168,6 +169,32 @@ func DownloadFromAbs(ctx context.Context, iClient interface{}, path string, writ
 		return err
 	}
 	a, c, p := initAbsVariables(pSplit)
+
+	// Section to be tested - START
+
+	// If this works (or a similar version of it)
+	// we can replace the entire "Section to be replaced"
+	// this acheiving a stream from ABS
+	// To make this work - uncomment the 'storage' import
+	// References:
+	// https://medium.com/@matryer/introducing-stow-cloud-storage-abstraction-package-for-go-20cf2928d93c
+	// https://github.com/graymeta/stow/blob/master/azure/item.go#L46
+
+	// var client storage.BlobStorageClient
+	// reader, err := client.GetContainerReference(c).GetBlobReference(p).Get(nil)
+	// defer reader.Close()
+	// if err != nil {
+	// 	return err
+	// }
+	// _, err = io.Copy(writer, reader)
+	// if err != nil {
+	// 	return err
+	// }
+
+	// Section to be tested - END
+
+	// Section to be replaced - START
+
 	pl := iClient.(pipeline.Pipeline)
 	cu, err := getContainerURL(pl, a, c)
 	if err != nil {
@@ -187,9 +214,11 @@ func DownloadFromAbs(ctx context.Context, iClient interface{}, path string, writ
 		return err
 	}
 
-	// this is a workaround
-	// we do not want to save the entire file to memory
+	// this is a workaround - we do not want to save the entire file to memory
 	writer.Write(dd.Bytes())
+
+	// Section to be replaced - END
+
 	return nil
 }
 
