fix: update certificate approval command condition in NOTES.txt#130
Merged
fix: update certificate approval command condition in NOTES.txt#130
Conversation
schaubl
reviewed
Dec 9, 2024
Contributor
There was a problem hiding this comment.
I think you can also remove SET_MULTIPLE in kubernetes-credentials-manager-job.yaml
Contributor
Author
|
@schaubl Indeed. I didn't notice this. Thanks. |
|
schaubl
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works in tandem with nuvlaedge/nuvlaedge#227
The default CSR name is
nuvlaedge-csr. It is defined as default invalues.yamland assumed as the default inkubernetes-credentail-manager.shin this PR nuvlaedge/nuvlaedge#227. In the case of the default CSR name,kubernetes-credentail-manager.shandNOTES.txtgenerate CSR name asnuvlaedge-csr-<NE UUID>. Otherwise, the value provided invalues.yaml(that is different from the assumed default) will be used as the name of CSR.