Enable CPEx on non-production environments#4063
Merged
jloh02 merged 5 commits intonusmodifications:masterfrom May 25, 2025
Merged
Enable CPEx on non-production environments#4063jloh02 merged 5 commits intonusmodifications:masterfrom
jloh02 merged 5 commits intonusmodifications:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@gnimnix is attempting to deploy a commit to the modsbot's projects Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4063 +/- ##
==========================================
+ Coverage 54.52% 54.81% +0.29%
==========================================
Files 274 276 +2
Lines 6076 6352 +276
Branches 1455 1557 +102
==========================================
+ Hits 3313 3482 +169
- Misses 2763 2870 +107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Edit: realised I linked to the wrong ticket, closes #4051 |
This makes the variable for enableCPExforProd clearer, as well as to allow easy UI testing. Nonetheless, backend testing with API is still not possible other than on prod and cpex-staging
jloh02
approved these changes
May 25, 2025
Member
jloh02
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the updates! It satisfies lots of the considerations and requirements I had in mind too while abstracting it cleanly in config!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes #4051.
Implementation
Added CPEx to config and filter for
stagingordevelopmentenvironment (automatically enabling CPEx for staging and dev). Loads this config in CPEx view.Other Information
I have not written tests as I see that test environment is explicitly set to
testbut please correct me if this value can be modified during tests.