allow into filesize to take tables as input / output#9706
Merged
fdncred merged 7 commits intonushell:mainfrom Jul 16, 2023
Merged
allow into filesize to take tables as input / output#9706fdncred merged 7 commits intonushell:mainfrom
into filesize to take tables as input / output#9706fdncred merged 7 commits intonushell:mainfrom
Conversation
this should hopefully fix the CI - have the test running - do not require to have both a `list -> table` and `table -> table` tests
Member
Author
|
thanks @fdncred for pointing out the error in the example test 😌 |
Contributor
|
thanks. i bet we keep finding these for a while. |
Member
Author
oooh yeah definitely 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
i have the following command that should give a table of all the mounted devices with information about their sizes, etc, etc... a glorified output for the
df -hcommand:this should work given the first example of
into filesizebefore this PR
it does not even parse
with this PR
it parses again and gives
User-Facing Changes
into filesizeworks back with tables and this effectively fixes the doc.Tests + Formatting
toolkit fmttoolkit clippytoolkit testtoolkit test stdlibthis PR gives a
resultback to the first table example to make sure it works fine.After Submitting