Skip to content

FIX: filter the std help ... by name, usage and search terms#9035

Merged
fdncred merged 2 commits intonushell:mainfrom
amtoine:fix/stdlib/find-columns-in-help-commands
Apr 28, 2023
Merged

FIX: filter the std help ... by name, usage and search terms#9035
fdncred merged 2 commits intonushell:mainfrom
amtoine:fix/stdlib/find-columns-in-help-commands

Conversation

@amtoine
Copy link
Copy Markdown
Member

@amtoine amtoine commented Apr 28, 2023

Should close on of the points in

Description

this PR uses the new --columns option for find to filter the results of the std help commands on the usage, name and search_terms columns.

User-Facing Changes

the --find option of std help commands should match more closely the built-in help commands output.

Tests + Formatting

  • 🟢 toolkit fmt
  • 🟢 toolkit clippy
  • ⚫ toolkit test
  • ⚫ toolkit test stdlib

After Submitting

$nothing

@amtoine
filter any help result by name, usage and search terms
aaa6a37 
This should match the built-in more closely.
@amtoine amtoine added the A:std-library Defining and improving the standard library written in Nu label Apr 28, 2023
@amtoine amtoine requested a review from fdncred April 28, 2023 11:40
@amtoine amtoine self-assigned this Apr 28, 2023
@amtoine amtoine mentioned this pull request Apr 28, 2023
Open
9 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 28, 2023 •
edited
Loading

Codecov Report

Merging #9035 (aaa6a37) into main (4c4c1f6) will not change coverage.
The diff coverage is n/a.

❗ Current head aaa6a37 differs from pull request most recent head c07ff78. Consider uploading reports for the commit c07ff78 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9035   +/-   ##
=======================================
  Coverage   68.75%   68.75%           
=======================================
  Files         640      640           
  Lines      101433   101433           
=======================================
  Hits        69737    69737           
  Misses      31696    31696

@amtoine
update the search columns based on available columns
c07ff78 
For instance, `search_terms` is valid only with `help commands`.
@amtoine
Copy link
Copy Markdown
Member Author

amtoine commented Apr 28, 2023

that should be a bit better with the last commit @fdncred 😋

@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Apr 28, 2023

that should be a bit better with the last commit @fdncred 😋

That latest commit helps but std help modules -f blah doesn't output a table at all

@amtoine
Copy link
Copy Markdown
Member Author

amtoine commented Apr 28, 2023

That latest commit helps but std help modules -f blah doesn't output a table at all

yes, it's an issue that had been there since the beginning of these commands 👀

can i save that for after this lands? 😋 [

@amtoine amtoine mentioned this pull request Apr 28, 2023
Merged
fdncred
fdncred approved these changes Apr 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@fdncred fdncred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes work and we can land this on the promise that the other issues will be fixed in subsequent PR(s).

@fdncred fdncred merged commit 59b85e5 into nushell:main Apr 28, 2023
@amtoine amtoine deleted the fix/stdlib/find-columns-in-help-commands branch April 28, 2023 17:33
@amtoine amtoine mentioned this pull request May 1, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fdncred fdncred fdncred approved these changes

Assignees

@amtoine amtoine

Labels

A:std-library Defining and improving the standard library written in Nu

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amtoine @fdncred