FIX: give same order in std help ... as in help ...#9034
Merged
fdncred merged 2 commits intonushell:mainfrom Apr 28, 2023
Merged
FIX: give same order in std help ... as in help ...#9034fdncred merged 2 commits intonushell:mainfrom
std help ... as in help ...#9034fdncred merged 2 commits intonushell:mainfrom
Conversation
9 tasks
std help operators as in help operatorsstd help ... as in help ...
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9034 +/- ##
==========================================
+ Coverage 68.75% 68.76% +0.01%
==========================================
Files 640 640
Lines 101433 101433
==========================================
+ Hits 69737 69749 +12
+ Misses 31696 31684 -12 |
fdncred
approved these changes
Apr 28, 2023
Contributor
fdncred
left a comment
There was a problem hiding this comment.
I tested it and it looks good. thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should close on of the points in
helpand the implementations innu-std#8813Description
before this PR, we had a problem
would give
this PR removes the
namesorting so that the orders are the same between thestdimplementation and the built-in one.User-Facing Changes
the operators in
std help ...will be sorted just as the built-inhelp ....Tests + Formatting
toolkit fmttoolkit clippytoolkit testtoolkit test stdlibAfter Submitting