Skip to content

FEATURE: add the bench command to the standard library#8969

Merged
amtoine merged 4 commits intonushell:mainfrom
amtoine:feature/stdlib/add-bench-command
Apr 28, 2023
Merged

FEATURE: add the bench command to the standard library#8969
amtoine merged 4 commits intonushell:mainfrom
amtoine:feature/stdlib/add-bench-command

Conversation

@amtoine
Copy link
Copy Markdown
Member

@amtoine amtoine commented Apr 22, 2023

Should address the first point of

Description

i've seen a few appearances of this benchmark idea in recent works on nu-std, so i thought it would be great to add it finally.

User-Facing Changes

a new std bench command to measure the performance of nushell closures and code blocks.

Tests + Formatting

  • 🟢 toolkit fmt
  • 🟢 toolkit clippy
  • toolkit test
  • 🟢 toolkit test stdlib

After Submitting

$nothing

@amtoine amtoine added the A:std-library Defining and improving the standard library written in Nu label Apr 22, 2023
@amtoine amtoine self-assigned this Apr 22, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 22, 2023

Codecov Report

Merging #8969 (da47990) into main (0cc735a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8969   +/-   ##
=======================================
  Coverage   68.56%   68.56%           
=======================================
  Files         636      636           
  Lines      101772   101772           
=======================================
  Hits        69776    69776           
  Misses      31996    31996           

@amtoine amtoine merged commit 3268ecd into nushell:main Apr 28, 2023
@amtoine amtoine deleted the feature/stdlib/add-bench-command branch April 28, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A:std-library Defining and improving the standard library written in Nu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant