allow custom commands to show up in $nu.scope.commands better#8910
Merged
fdncred merged 2 commits intonushell:mainfrom Apr 17, 2023
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8910 +/- ##
==========================================
+ Coverage 68.16% 68.55% +0.38%
==========================================
Files 636 636
Lines 101691 101706 +15
==========================================
+ Hits 69321 69724 +403
+ Misses 32370 31982 -388
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows our custom commands to show up in
$nu.scope.commandsbetter. It still needs work because this PR hard code the input and output types asType::Anybut the reason they're being missed in the first place is that they are not assigned an input and output type.This allows things like this now. Note the
where is_custom == trueAnother example.
User-Facing Changes
Tests + Formatting
After Submitting