Skip to content

Allocate less when doing a capture discovery#8903

Merged
sophiajt merged 1 commit intonushell:mainfrom
sophiajt:discover_capture_allocate_less
Apr 16, 2023
Merged

Allocate less when doing a capture discovery#8903
sophiajt merged 1 commit intonushell:mainfrom
sophiajt:discover_capture_allocate_less

Conversation

@sophiajt
Copy link
Copy Markdown
Contributor

Description

This should be a little more efficient when running the algorithm to find the captured variables.

User-Facing Changes

Tests + Formatting

After Submitting

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2023

Codecov Report

Merging #8903 (1227369) into main (6b32367) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8903      +/-   ##
==========================================
- Coverage   68.52%   68.15%   -0.37%     
==========================================
  Files         636      636              
  Lines      101669   101692      +23     
==========================================
- Hits        69665    69308     -357     
- Misses      32004    32384     +380     
Impacted Files Coverage Δ
crates/nu-parser/src/parser.rs 85.37% <100.00%> (-0.01%) ⬇️
src/tests.rs 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@sophiajt sophiajt merged commit bf3bb66 into nushell:main Apr 16, 2023
@sophiajt sophiajt deleted the discover_capture_allocate_less branch April 16, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant