Replace #8824: CONTRIBUTING.md for standard library#8894
Merged
amtoine merged 1 commit intonushell:mainfrom Apr 17, 2023
Merged
Replace #8824: CONTRIBUTING.md for standard library#8894amtoine merged 1 commit intonushell:mainfrom
amtoine merged 1 commit intonushell:mainfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8894 +/- ##
==========================================
+ Coverage 68.15% 68.53% +0.37%
==========================================
Files 636 636
Lines 101669 101676 +7
==========================================
+ Hits 69292 69679 +387
+ Misses 32377 31997 -380
|
Member
|
should close #8810 |
amtoine
approved these changes
Apr 16, 2023
Member
|
thanks @bobhy for the document 🥳 😋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces #8824, which was languishing in review limbo and becoming increasingly difficult to keep current with upstream changes.
In addition to all the edits, this PR includes updated documentation for running unit tests via
std run-tests.User-Facing Changes
A CONTRIBUTING.md documenting guidelines and getting started info for potential stdlib contributors.
Tests + Formatting
After Submitting