Skip to content

add LICENSE to nu-std#8803

Merged
stormasm merged 1 commit intonushell:mainfrom
stormasm:std-license
Apr 7, 2023
Merged

add LICENSE to nu-std#8803
stormasm merged 1 commit intonushell:mainfrom
stormasm:std-license

Conversation

@stormasm
Copy link
Copy Markdown
Contributor

@stormasm stormasm commented Apr 7, 2023

Description

(Thank you for improving Nushell. Please, check our contributing guide and talk to the core team before making major changes.)

(Description of your pull request goes here. Provide examples and/or screenshots if your changes affect the user experience.)

User-Facing Changes

(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass
  • cargo run -- crates/nu-std/tests.nu to run the tests for the standard library

Note
from nushell you can also use the toolkit as follows

use toolkit.nu  # or use an `env_change` hook to activate it automatically
toolkit check pr

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@stormasm stormasm merged commit 5ec6edb into nushell:main Apr 7, 2023
@stormasm stormasm deleted the std-license branch April 7, 2023 20:39
@amtoine
Copy link
Copy Markdown
Member

amtoine commented Apr 8, 2023

cool 👍

@amtoine amtoine mentioned this pull request Apr 8, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants