FEATURE: better ansi -e error #8709
Merged
sholderbach merged 4 commits intonushell:mainfrom Apr 5, 2023
Merged
Conversation
fdncred
reviewed
Apr 2, 2023
Contributor
|
apparently there are conflicts to resolve, or i'd land this. |
…better-ansi-e-error This solves the merge conflicts.
Member
Author
should be fixed in e926354 😋 if the tests pass, i think we're good with these new errors 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should close #8704.
Description
this PR
ansi -e {invalid: "invalid"}more explicitansi -eexample more explicit about valid / invalid keysUser-Facing Changes
the error
the new
ansi -eexampleTests + Formatting
toolkit fmttoolkit clippytoolkit testtoolkit test stdlibAfter Submitting