Skip to content

Make optional cell paths work with reject#8697

Merged
rgwood merged 1 commit intonushell:mainfrom
rgwood:optional-reject
Mar 31, 2023
Merged

Make optional cell paths work with reject#8697
rgwood merged 1 commit intonushell:mainfrom
rgwood:optional-reject

Conversation

@rgwood
Copy link
Copy Markdown
Contributor

@rgwood rgwood commented Mar 31, 2023

This PR makes ? work with reject. For example:

> {} | reject foo
Error: nu::shell::column_not_found

  × Cannot find column
   ╭─[entry #2:1:1]
 1 │ {} | reject foo
   ·      ───┬── ─┬─
   ·         │    ╰── cannot find column 'foo'
   ·         ╰── value originates here
   ╰────

> {} | reject foo?
╭──────────────╮
│ empty record │
╰──────────────╯

This was prompted by a user question. I would like to get this in for 0.78, I think it's low-risk and I want the ? feature to be as polished as possible for its debut.

@rgwood rgwood merged commit 83ddf0e into nushell:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant