Skip to content

fix test_default_config_path test after pr 8653#8690

Merged
fdncred merged 5 commits intonushell:mainfrom
fdncred:fix_default_config_path_test
Mar 31, 2023
Merged

fix test_default_config_path test after pr 8653#8690
fdncred merged 5 commits intonushell:mainfrom
fdncred:fix_default_config_path_test

Conversation

@fdncred
Copy link
Copy Markdown
Contributor

@fdncred fdncred commented Mar 31, 2023

Description

This PR fixes a testing bug that @rgwood found and PR #8653 introduced, mentioned here. Since 8653 returns canonicalizes config paths now, the tests need to return canonicalized paths as well. Without this PR, if you have your nushell config dir symlinked, this test will fail. This PR fixes that test.

User-Facing Changes

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass
  • cargo run -- crates/nu-utils/standard_library/tests.nu to run the tests for the standard library

Note
from nushell you can also use the toolkit as follows

use toolkit.nu  # or use an `env_change` hook to activate it automatically
toolkit check pr

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@fdncred fdncred merged commit b2257a5 into nushell:main Mar 31, 2023
@fdncred fdncred deleted the fix_default_config_path_test branch March 31, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant