feature: add the standard library tests to the PR template and the toolkit#8629
Merged
sholderbach merged 3 commits intonushell:mainfrom Mar 30, 2023
Conversation
Member
Author
|
i think this PR is ready 😋 |
Member
|
Ship it! |
Member
Author
noishe, thanks 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #8525.
Description
With #8525, the tests for the standard library have been enabled in the CI.
The only places where these tests are missing are
This PR adds
cargo run -- crates/nu-utils/standard_library/tests.nuto the PR templatetoolkit test stdlibtest stdlibcommand totoolkit check prUser-Facing Changes
Tests + Formatting
the new output of
toolkit check pr, with the same color code:After Submitting