Skip to content

REFACTOR: remove the help commands#8611

Closed
amtoine wants to merge 3 commits intonushell:mainfrom
amtoine:refactor/stdlib/remove-the-help-commands-from-rust
Closed

REFACTOR: remove the help commands#8611
amtoine wants to merge 3 commits intonushell:mainfrom
amtoine:refactor/stdlib/remove-the-help-commands-from-rust

Conversation

@amtoine
Copy link
Copy Markdown
Member

@amtoine amtoine commented Mar 25, 2023

Related to #8505.

Warning
we do not want to merge this PR until we have a proper way to ship the standard library.
this is just a preliminary work to prepare the transition 😌

Description

this PR

  • removes the implementation of all the help commands
  • removes all the tests involving a call to one of the help commands

Note
in 48a1f35, we have the list of all the removed tests.
i plan on moving them to the standard library itself once #8525 lands 👍

User-Facing Changes

users would have to use the help commands provided by the standard library in #8505.

Tests + Formatting

  • 🟢 toolkit fmt
  • 🟢 toolkit clippy
  • 🟢 toolkit test

After Submitting

mention in the announcement of the standard library?
or maybe not mandatory if we have a proper "prelude"!

amtoine added 3 commits March 25, 2023 12:28
@amtoine
remove all the help commands from the source
41d9211
@amtoine
move highlight_search_string to find directly
1d2cfa7 
This function was previously defined in the help commands and
imported in the `find` command.
This commit removes the dependency to the removed file by
putting the function directly in `find`.
@amtoine
remove all tests containing calls to the help commands
48a1f35
@amtoine
Copy link
Copy Markdown
Member Author

amtoine commented Mar 25, 2023

maybe this one would need the same label as the previous "removal" PRs? 😋

even though wait-until-after-nushell-release is not really the right label 🤔

@fdncred fdncred added the A:std-library Defining and improving the standard library written in Nu label Mar 25, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2023

Codecov Report

Merging #8611 (48a1f35) into main (d8478ca) will increase coverage by 0.04%.
The diff coverage is 64.70%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8611      +/-   ##
==========================================
+ Coverage   68.53%   68.57%   +0.04%     
==========================================
  Files         631      625       -6     
  Lines      101962   100913    -1049     
==========================================
- Hits        69875    69197     -678     
+ Misses      32087    31716     -371
Impacted Files Coverage Δ
crates/nu-cmd-lang/src/default_context.rs 98.43% <ø> (-0.14%) ⬇️
crates/nu-command/src/filters/find.rs 75.68% <64.70%> (-1.12%) ⬇️

... and 14 files with indirect coverage changes

This was referenced Mar 25, 2023
Open
Merged
Open
Merged
@amtoine amtoine mentioned this pull request Apr 8, 2023
Open
9 tasks
@amtoine
Copy link
Copy Markdown
Member Author

amtoine commented Apr 28, 2023

📯 to make the transition easier to manage, we'll close this and move the commands from rust to nu-std one at a time 😋

@amtoine amtoine closed this Apr 28, 2023
@amtoine amtoine deleted the refactor/stdlib/remove-the-help-commands-from-rust branch May 26, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A:std-library Defining and improving the standard library written in Nu

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amtoine @fdncred