Cell paths: make optional path members short-circuit#8554
Merged
sophiajt merged 1 commit intonushell:mainfrom Mar 22, 2023
Merged
Cell paths: make optional path members short-circuit#8554sophiajt merged 1 commit intonushell:mainfrom
sophiajt merged 1 commit intonushell:mainfrom
Conversation
Member
|
that's very nice 😮 |
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #8379 and #8502.
This PR makes it so that the new
?syntax for marking a path member as optional short-circuits, as voted on in the 8502 poll. Previously,{ foo: 123 }.bar?.bazwould raise an error:Here's what was happening:
bar?path member access returnsnothingbecause there is no field namedbaron the recordbazpath member access fails when trying to access abazfield on thatnothingvalueAfter this change,
{ foo: 123 }.bar?.bazreturnsnothing; the failedbar?access immediately returnsnothingand thebazaccess never runs.