Skip to content

standard library: fix the tests for the new closure parsing of 0.77.2#8504

Merged
sophiajt merged 1 commit intonushell:mainfrom
amtoine:fix/standard-library-tests-for-0-77-2
Mar 17, 2023
Merged

standard library: fix the tests for the new closure parsing of 0.77.2#8504
sophiajt merged 1 commit intonushell:mainfrom
amtoine:fix/standard-library-tests-for-0-77-2

Conversation

@amtoine
Copy link
Copy Markdown
Member

@amtoine amtoine commented Mar 17, 2023

Description

as closures now need to have explicit parameters, this PR adds the empty || to the two closure of the std match test.

User-Facing Changes

$nothing

Tests + Formatting

nu crates/nu-utils/standard_library/tests.nu

does not give the following anymore

Error: nu::parser::closure_missing_pipe

  × Missing || inside closure
    ╭─[/home/amtoine/.local/share/git/store/github.com/amtoine/nushell/crates/nu-utils/standard_library/test_std.nu:29:1]
 29 │     let branches = {
 30 │         1: { -1 }
    ·            ───┬──
    ·               ╰── Parsing as a closure, but || is missing
 31 │         2: { -2 }
    ╰────
  help: Try add || to the beginning of closure

Error: nu::shell::only_supports_this_input_type

  × Input type not supported.
    ╭─[/home/amtoine/.local/share/git/store/github.com/amtoine/nushell/crates/nu-utils/standard_library/tests.nu:7:1]
  7 │             nu -c $'use ($test_file) *; $nu.scope.commands | to nuon'
  8 │             | from nuon
    ·               ────┬────
    ·                   ╰── input type: nothing
  9 │             | where module_name == $module_name
    ·               ──┬──
    ·                 ╰── only list, binary, raw data or range input data is supported
 10 │             | where ($it.name | str starts-with "test_")
    ╰────

After Submitting

$nothing

@sophiajt sophiajt merged commit 14bf0b0 into nushell:main Mar 17, 2023
@amtoine amtoine deleted the fix/standard-library-tests-for-0-77-2 branch March 18, 2023 07:49
@sholderbach sholderbach added the A:std-library Defining and improving the standard library written in Nu label Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A:std-library Defining and improving the standard library written in Nu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants